cryptoe commented on code in PR #16556:
URL: https://github.com/apache/druid/pull/16556#discussion_r1628076745
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/PartialGenericSegmentMergeTask.java:
##########
@@ -67,7 +67,7 @@ public PartialGenericSegmentMergeTask(
@JsonProperty("numAttempts") final int numAttempts, // zero-based
counting
@JsonProperty("spec") final PartialSegmentMergeIngestionSpec
ingestionSchema,
@JsonProperty("context") final Map<String, Object> context,
- @JsonProperty("centralizedDatasourceSchemaConfig")
CentralizedDatasourceSchemaConfig centralizedDatasourceSchemaConfig,
+ @JsonProperty("centralizedDatasourceSchemaConfig") @Nullable
CentralizedDatasourceSchemaConfig centralizedDatasourceSchemaConfig,
Review Comment:
Can we do a quick grep for CentralizedDatasourceSchemaConfig and see we have
nullable's everywhere ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
