Akshat-Jain commented on code in PR #16557:
URL: https://github.com/apache/druid/pull/16557#discussion_r1628194891
##########
processing/src/main/java/org/apache/druid/query/lookup/LookupExtractorFactoryContainerProvider.java:
##########
@@ -40,4 +40,9 @@ public interface LookupExtractorFactoryContainerProvider
* Returns a lookup container for the provided lookupName, if it exists.
*/
Optional<LookupExtractorFactoryContainer> get(String lookupName);
+
+ /**
+ * Returns the canonical lookup name from a lookup name.
+ */
+ String getCanonicalLookupName(String lookupName);
Review Comment:
@LakshSingla
I had a discussion with @abhishekrb19 about the naming of this method. We
concluded on getCanonicalLookupName().
Regarding the other comments:
1. I don't see the other methods marked as PublicApi either? So seems like
an unrelated issue to this PR? Thoughts?
2. This would be used in Imply extension. Would raise an Imply PR once this
merges where it would be more clear. But in general, if in future we add a
lookup name with special syntaxing, then this would be needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
