amaechler commented on code in PR #16561:
URL: https://github.com/apache/druid/pull/16561#discussion_r1631537767
##########
extensions-core/azure-extensions/src/main/java/org/apache/druid/storage/azure/AzureDataSegmentConfig.java:
##########
@@ -21,12 +21,15 @@
import com.fasterxml.jackson.annotation.JsonProperty;
+import javax.validation.constraints.NotNull;
+
/**
- * Stores the configuration for segments written to Azure deep storage
+ * Stores the configuration for segments written to Azure deep storage.
*/
public class AzureDataSegmentConfig
{
@JsonProperty
+ @NotNull
private String container;
Review Comment:
I believe this config is only instantiated and validated once used (in the
storage module). I tested this locally quickly by loading the azure extension,
but not configuring Druid to use the extension for deep storage, and was able
to step through ingestion successfully.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
