abhishekrb19 commented on code in PR #16582: URL: https://github.com/apache/druid/pull/16582#discussion_r1633923963
########## docs/configuration/index.md: ########## @@ -1249,9 +1249,9 @@ A `javascript` option is also available but should only be used for prototyping If an `affinityConfig` is provided (as part of `fillCapacity` and `equalDistribution` strategies) for a given task, the list of workers eligible to be assigned is determined as follows: - a non-affinity worker if no affinity is specified for that datasource. Any worker not listed in the `affinityConfig` is considered a non-affinity worker. -- a non-affinity worker if preferred workers are not available and the affinity is _weak_ i.e. `strong: false`. +- a non-affinity worker if preferred workers are not available and the affinity is *weak* i.e. `strong: false`. Review Comment: Since we use the google style [docs](https://github.com/apache/druid/blob/master/docs/development/docs-contribute.md#style-guide), it's [recommended](https://developers.google.com/style/text-formatting) to use `_` over `*` for italics: > Use italics formatting, <i> or _, when drawing attention to a specific word or phrase, such as when [defining terms](https://developers.google.com/style/formatting-key-terms) or [using words as words](https://developers.google.com/style/formatting-words-as-words). Although an asterisk, *, can also indicate italics in Markdown, we recommend underscores to make it easier for humans to distinguish italics from bold in the Markdown file. ########## docs/configuration/index.md: ########## @@ -1316,7 +1316,7 @@ Tasks are assigned to the worker with the most currently-running tasks. This is useful when you are auto-scaling MiddleManagers since it tends to pack some full and leave others empty. The empty ones can be safely terminated. -Note that if `druid.indexer.runner.pendingTasksRunnerNumThreads` is set to _N_ > 1, then this strategy will fill _N_ +Note that if `druid.indexer.runner.pendingTasksRunnerNumThreads` is set to *N* > 1, then this strategy will fill *N* Review Comment: Same here & below ########## docs/configuration/index.md: ########## @@ -1955,7 +1956,7 @@ The Druid SQL server is configured through the following properties on the Broke |`druid.sql.planner.useApproximateCountDistinct`|Whether to use an approximate cardinality algorithm for `COUNT(DISTINCT foo)`.|true| |`druid.sql.planner.useGroupingSetForExactDistinct`|Only relevant when `useApproximateCountDistinct` is disabled. If set to true, exact distinct queries are re-written using grouping sets. Otherwise, exact distinct queries are re-written using joins. This should be set to true for group by query with multiple exact distinct aggregations. This flag can be overridden per query.|false| |`druid.sql.planner.useApproximateTopN`|Whether to use approximate [TopN queries](../querying/topnquery.md) when a SQL query could be expressed as such. If false, exact [GroupBy queries](../querying/groupbyquery.md) will be used instead.|true| -|`druid.sql.planner.requireTimeCondition`|Whether to require SQL to have filter conditions on __time column so that all generated native queries will have user specified intervals. If true, all queries without filter condition on __time column will fail|false| +|`druid.sql.planner.requireTimeCondition`|Whether to require SQL to have filter conditions on __time column so that all generated native queries will have user specified intervals. If true, all queries without filter condition on__time column will fail|false| Review Comment: Space is accidentally squashed? ```suggestion |`druid.sql.planner.requireTimeCondition`|Whether to require SQL to have filter conditions on __time column so that all generated native queries will have user specified intervals. If true, all queries without filter condition on __time column will fail|false| ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
