kgyrtkirk commented on code in PR #16583:
URL: https://github.com/apache/druid/pull/16583#discussion_r1634417289
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/QueryHandler.java:
##########
@@ -684,16 +684,7 @@ private DruidException
buildSQLPlanningError(RelOptPlanner.CannotPlanException e
.ofCategory(DruidException.Category.UNSUPPORTED)
.build(exception, "Unhandled Query Planning Failure,
see broker logs for details");
} else {
- // Planning errors are more like hints: it isn't guaranteed that the
planning error is actually what went wrong.
- // For this reason, we consider these as targetting a more expert
persona, i.e. the admin instead of the actual
- // user.
Review Comment:
The removed comment provides the reason why it was not target to the `USER`
; I think we should leave the uncategorized ones to `ADMIN` or something
if there is a particular set of exceptions which should be hardened; maybe
those should be targeted directly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
