kgyrtkirk commented on code in PR #16504:
URL: https://github.com/apache/druid/pull/16504#discussion_r1634819130
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteQueryTest.java:
##########
@@ -5207,11 +5233,15 @@ public void testCaseFilteredAggregationWithGroupBy()
.setInterval(querySegmentSpec(Filtration.eternity()))
.setGranularity(Granularities.ALL)
.setDimensions(dimensions(new
DefaultDimensionSpec("cnt", "d0", ColumnType.LONG)))
+ .setVirtualColumns(
+ expressionVirtualColumn(
+ "v0",
+ "case_searched((\"dim1\" != '1'),1,0)",
Review Comment:
this `CASE` statement was retained because the transformation to `COUNT` may
change behaviour when there are `0` input rows;
I've some ideas how to fix this - but didn't got to it yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
