maytasm commented on PR #14329: URL: https://github.com/apache/druid/pull/14329#issuecomment-2161534834
@a2l007 +1 on calling this out in the docs and also print some warning error messages. This solution would also not break any existing jobs (since we are only adding side effects like loggings, etc). Regarding filter pushdown, I think both ways work. Maybe we can check if the filter we pass to Iceberg scan API returns residual or not (I think there is a ResidualEvaluator class in Iceberg that provides this information). If it does not return residual then we can proceed without filter push down (the current behavior today). If there is residual, then we can transform the iceberg filters into Druid's filter (filterSpec) and pass it to Druid ingestionSpec. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
