clintropolis commented on code in PR #16569:
URL: https://github.com/apache/druid/pull/16569#discussion_r1635560935
##########
server/src/main/java/org/apache/druid/client/CacheUtil.java:
##########
@@ -34,6 +34,8 @@
public class CacheUtil
{
+ private static final String RESULT_CACHE_NS = "ResultCacheNS";
Review Comment:
nit: maybe make a version of `NamedKey` for result cache where the `nsBytes`
is already computed so we don't have to call `StringUtils.toUtf8` on the
constant everytime. Also could probably use a smaller string since the segment
level cache uses segment identifiers for the namespace, so unlikely to have any
collisions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
