clintropolis commented on code in PR #16529:
URL: https://github.com/apache/druid/pull/16529#discussion_r1635626969
##########
processing/src/main/java/org/apache/druid/segment/incremental/IncrementalIndex.java:
##########
@@ -608,7 +608,7 @@ IncrementalIndexRowResult toIncrementalIndexRow(InputRow
row)
Object dimsKey = null;
try {
final EncodedKeyComponent<?> encodedKeyComponent
- =
indexer.processRowValsToUnsortedEncodedKeyComponent(row.getRaw(dimension),
true);
+ =
indexer.processRowValsToUnsortedEncodedKeyComponent(row.getRaw(dimension),
true, dimension);
Review Comment:
hmm, do we really need to pass this as an argument for every value of every
row? maybe it would be better to just initialize the dimension indexers with
their name instead.
Alternatively, we are already catching `ParseException`, why not add a way
to decorate it with an additional column name.
I guess i'm just being cautious about small overhead of additional arguments
and the default method impl adding up since this is a pretty hot function
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
