kfaraz commented on code in PR #16605:
URL: https://github.com/apache/druid/pull/16605#discussion_r1639867407
##########
server/src/main/java/org/apache/druid/metadata/IndexerSQLMetadataStorageCoordinator.java:
##########
@@ -1460,8 +1460,12 @@ int insertPendingSegmentsIntoMetastore(
));
final String now = DateTimes.nowUtc().toString();
+ final Set<String> processedSegmentIds = new HashSet<>();
Review Comment:
It makes the code easier to understand. Having a set of
`SegmentIdWithShardSpec` would have the exact same effect since the equals and
hashCode of `SegmentIdWithShardSpec` uses the same id which is returned in
`toString()`.
IIRC, the original code (i.e. pre-`PendingSegmentRecord`) was also
maintaining a set of `SegmentIdWithShardSpec`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
