YongGang commented on code in PR #16600:
URL: https://github.com/apache/druid/pull/16600#discussion_r1640157089
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/execution/SelectorBasedPodTemplateSelectStrategy.java:
##########
@@ -64,9 +60,9 @@ public PodTemplate getPodTemplateForTask(Task task,
Map<String, PodTemplate> tem
.filter(selector -> selector.evaluate(task))
.findFirst()
.map(Selector::getSelectionKey)
- .orElse(defaultKey);
+ .orElse("base");
- return templates.getOrDefault(templateKey, templates.get("base"));
Review Comment:
This change is not right, there is a matched template key doesn't mean the
template exist, fallback to `base` template key doesn't solve this problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
