maytasm opened a new pull request, #16610:
URL: https://github.com/apache/druid/pull/16610
Allow user to override/specify python exec to use for build
### Description
Building Druid requires Python to execute some python script like
generate-binary-notice.py and generate-binary-license.py. These scripts may
require packages to be installed (i.e. pyyaml). Some build environments may
have python3 available but prevent job (running on that worker) to install
packages to the machine python. These environments requires Python venv to be
setup. This PR allows such Python venv to be specify and use in the build
process.
i.e. An example build step
python -m venv .venv
.venv/bin/pip install pyyaml
mvn clean install package -Dpython.exec=.venv/bin/python
-Pbundle-contrib-exts -Pdist....
This PR has:
- [x] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
