kfaraz commented on code in PR #16612:
URL: https://github.com/apache/druid/pull/16612#discussion_r1640683404
##########
indexing-service/src/main/java/org/apache/druid/indexing/overlord/ForkingTaskRunner.java:
##########
@@ -924,6 +924,11 @@ public CommandListBuilder addSystemProperty(String
property, boolean value)
return addSystemProperty(property, String.valueOf(value));
}
+ public CommandListBuilder addSystemProperty(String property, Object value)
Review Comment:
This new method feels unnecessary.
Maybe we can use the approach used in #16281 instead.
Since the original author has not responded on that PR, we can proceed with
this one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
