LakshSingla commented on code in PR #16619:
URL: https://github.com/apache/druid/pull/16619#discussion_r1644588700
##########
processing/src/main/java/org/apache/druid/query/scan/ScanResultValueFramesIterable.java:
##########
@@ -200,26 +229,33 @@ public FrameSignaturePair next()
// start all the processing
populateCursor();
boolean firstRowWritten = false;
- // While calling populateCursor() repeatedly, currentRowSignature might
change. Therefore we store the signature
+ // While calling populateCursor() repeatedly, currentRowSignature might
change. Therefore, we store the signature
// with which we have written the frames
- final RowSignature writtenSignature = currentRowSignature;
+ final RowSignature writtenSignature = trimmedRowSignature;
Review Comment:
`frameWriterFactory.signature()` looks cleaner. Thanks for the suggestion,
I'll use that instead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
