kfaraz commented on code in PR #16609:
URL: https://github.com/apache/druid/pull/16609#discussion_r1650274012
##########
server/src/main/java/org/apache/druid/server/coordination/SegmentLoadDropHandler.java:
##########
@@ -326,9 +326,10 @@ private List<DataSegment> getBootstrapSegments()
List<DataSegment> bootstrapSegments = new ArrayList<>();
- try (final CloseableIterator<DataSegment> iterator =
-
FutureUtils.getUnchecked(coordinatorClient.fetchBootstrapSegments(), true)) {
- bootstrapSegments = ImmutableList.copyOf(iterator);
+ try {
+ final BootstrapSegmentsInfo response =
+ FutureUtils.getUnchecked(coordinatorClient.fetchBootstrapSegments(),
true);
Review Comment:
Sounds good. What about success scenarios, where a historical or task is
busy loading a lot of segments and thus may not respond to liveness probes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
