cryptoe commented on code in PR #16579:
URL: https://github.com/apache/druid/pull/16579#discussion_r1650385760
##########
processing/src/main/java/org/apache/druid/frame/write/FrameWriterUtils.java:
##########
@@ -251,9 +252,13 @@ public static void copyByteBufferToMemory(
final WritableMemory dst,
final long dstPosition,
final int len,
- final boolean allowNullBytes
+ final boolean allowNullBytes,
+ final boolean removeNullBytes
)
{
+ if (allowNullBytes && removeNullBytes) {
Review Comment:
This is quite hot piece of code. Do we wanna have this check here ?
##########
processing/src/main/java/org/apache/druid/frame/write/FrameWriterUtils.java:
##########
@@ -251,9 +252,13 @@ public static void copyByteBufferToMemory(
final WritableMemory dst,
final long dstPosition,
final int len,
- final boolean allowNullBytes
+ final boolean allowNullBytes,
+ final boolean removeNullBytes
)
{
+ if (allowNullBytes && removeNullBytes) {
Review Comment:
Instead can we make public static methods which never allow this condition
to happen ?
We can make this a private method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
