cryptoe commented on code in PR #16536:
URL: https://github.com/apache/druid/pull/16536#discussion_r1650426626
##########
server/src/main/java/org/apache/druid/segment/metadata/SegmentSchemaBackFillQueue.java:
##########
@@ -179,16 +179,15 @@ public void processBatchesDue()
entry.getValue(),
CentralizedDatasourceSchemaConfig.SCHEMA_VERSION
);
-
- // Mark the segments as published in the cache.
- for (SegmentSchemaMetadataPlus plus : entry.getValue()) {
-
segmentSchemaCache.markMetadataQueryResultPublished(plus.getSegmentId());
- }
emitter.emit(
ServiceMetricEvent.builder()
.setDimension(DruidMetrics.DATASOURCE,
entry.getKey())
.setMetric("metadatacache/backfill/count",
entry.getValue().size())
);
+ // Mark the segments as published in the cache.
Review Comment:
I think the order should be the one before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
