kfaraz commented on PR #16652: URL: https://github.com/apache/druid/pull/16652#issuecomment-2191528431
> I think my problem here is the word 'pending' which seems like something you wouldn't want to be using in stuff like query processing because it sounds like something that isn't 'official' yet Agreed. I have myself been on the fence about the 'pending' part too as it is certainly confusing. But then, I am not sure what a better alternative would have been either (maybe `open`, `appending` or `appendable` itself 😛 ). In that regard, I do like `AppendableSegment` as it does clarify that this is a segment to which we _can_ currently append more rows. I just wanted to be sure before we introduced a new(-ish) term in the code. You seem to have given it enough thought and I do agree with the arguments against the other options, so let's go ahead with `AppendableSegment`! I don't think we need to rename `Appenderator` as it works fine for its role. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
