abhishekrb19 opened a new pull request, #16685:
URL: https://github.com/apache/druid/pull/16685
Marking this as draft to let CI run and a few more things need to be
addressed.
The `SegmentLoadDropHandler` code currently supports the following
functionalities:
1. Bootstrapping on startup:
a. Loading previously cached segments
b. Fetching and loading bootstrap segments from the coordinator
2. Loading segments
3. Dropping segments
4. Batch operations
The current structure of the code makes it difficult to add new
functionality. Therefore, this PR proposes splitting the functionality into two
separate components:
1. `SegmentBootstrapper`: Responsible for bootstrapping functions
2. `SegmentLoadDropHandler`: Responsible for segment change handling
functions — `addSegment()`, `removeSegment()`, and `processBatch()`
Apart from improving code hygiene, this refactoring allows for
customizations in the bootstrapping code without affecting the load/drop
functionality. Some potential customizations in the bootstrapping flow include
selective loading of segments by tasks and server-specific segment loading.
This change does not introduce any new functional changes.
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
