kfaraz commented on code in PR #16291: URL: https://github.com/apache/druid/pull/16291#discussion_r1666316643
########## server/src/test/java/org/apache/druid/server/http/CoordinatorCompactionConfigsResourceTest.java: ########## @@ -24,6 +24,7 @@ import org.apache.druid.audit.AuditManager; import org.apache.druid.common.config.ConfigManager; import org.apache.druid.common.config.JacksonConfigManager; +import org.apache.druid.indexer.CompactionEngine; Review Comment: There should also be a couple of tests that verify the exception and message that is thrown when an invalid config is passed. All the validation cases need not be captured as we are already doing that in `ClientCompactionRunnerInfoTest`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
