findingrish commented on code in PR #16676:
URL: https://github.com/apache/druid/pull/16676#discussion_r1666724844
##########
server/src/main/java/org/apache/druid/segment/metadata/CoordinatorSegmentMetadataCache.java:
##########
@@ -92,14 +114,27 @@ public CoordinatorSegmentMetadataCache(
InternalQueryConfig internalQueryConfig,
ServiceEmitter emitter,
SegmentSchemaCache segmentSchemaCache,
- SegmentSchemaBackFillQueue segmentSchemaBackfillQueue
+ SegmentSchemaBackFillQueue segmentSchemaBackfillQueue,
+ SqlSegmentsMetadataManager sqlSegmentsMetadataManager,
+ SegmentReplicationStatusManager segmentReplicationStatusManager,
+ Supplier<SegmentsMetadataManagerConfig>
segmentsMetadataManagerConfigSupplier
)
{
super(queryLifecycleFactory, config, escalator, internalQueryConfig,
emitter);
this.config = config;
this.columnTypeMergePolicy = config.getMetadataColumnTypeMergePolicy();
this.segmentSchemaCache = segmentSchemaCache;
this.segmentSchemaBackfillQueue = segmentSchemaBackfillQueue;
+ this.sqlSegmentsMetadataManager = sqlSegmentsMetadataManager;
+ this.segmentReplicationStatusManager = segmentReplicationStatusManager;
+ this.coldSchemaExecPeriodMillis =
+
segmentsMetadataManagerConfigSupplier.get().getPollDuration().getMillis();
+ coldScehmaExec = Executors.newSingleThreadScheduledExecutor(
+ new ThreadFactoryBuilder()
+ .setNameFormat("DruidColdSchema-ScheduledExecutor-%d")
+ .setDaemon(true)
Review Comment:
I will update, we don't need a daemon thread here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
