asdf2014 commented on code in PR #16656:
URL: https://github.com/apache/druid/pull/16656#discussion_r1668122897
##########
services/src/main/java/org/apache/druid/server/AsyncQueryForwardingServlet.java:
##########
@@ -104,7 +104,7 @@ public class AsyncQueryForwardingServlet extends
AsyncProxyServlet implements Qu
private static final String PROPERTY_SQL_ENABLE = "druid.router.sql.enable";
private static final String PROPERTY_SQL_ENABLE_DEFAULT = "false";
- private static final int CANCELLATION_TIMEOUT_MILLIS = 500;
+ private static final int CANCELLATION_TIMEOUT_MILLIS = 1000;
Review Comment:
Nit: let's avoid magic number :smile:
```suggestion
private static final int CANCELLATION_TIMEOUT_MILLIS =
TimeUnit.SECONDS.toMillis(1);;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
