Akshat-Jain commented on code in PR #16682: URL: https://github.com/apache/druid/pull/16682#discussion_r1668591798
########## extensions-core/datasketches/src/main/java/org/apache/druid/query/aggregation/datasketches/hll/sql/HllSketchBaseSqlAggregator.java: ########## Review Comment: @LakshSingla Yes. The signature matching happens only for APPROX_COUNT_DISTINCT() family of functions. So the changes in this layer are to handle `count (distinct column)`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
