zachjsh commented on code in PR #16719:
URL: https://github.com/apache/druid/pull/16719#discussion_r1672833377
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/KillUnusedSegments.java:
##########
@@ -249,6 +292,10 @@ private Interval findIntervalForKill(
stats.add(Stats.Kill.ELIGIBLE_UNUSED_SEGMENTS, datasourceKey,
unusedSegmentIntervals.size());
if (CollectionUtils.isNullOrEmpty(unusedSegmentIntervals)) {
+ log.info(
Review Comment:
I think this will log for each autoKill run cycle, for each datasource where
we do not find any segments to kill. Do you think this might get too chatty?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
