adarshsanjeev commented on code in PR #16708:
URL: https://github.com/apache/druid/pull/16708#discussion_r1673396029
##########
processing/src/main/java/org/apache/druid/segment/loading/MMappedQueryableSegmentizerFactory.java:
##########
@@ -34,9 +35,29 @@
*/
public class MMappedQueryableSegmentizerFactory implements SegmentizerFactory
{
+ /**
+ * A static method to make a segmentizer factory that can be serialized by
Jackson. This exists because the object
+ * doesn't actually need the IndexIO object in order to be serialized by
Jackson, but the public constructor
+ * *does* require it. We leave the public constructor alone because if
indexIO is null, this SegmentizerFactory
+ * is largely useless, so we just create this one static method to enable
creating the object for this singular
+ * use case.
+ *
+ * @return a SegmentizerFactory that can be used to be serialized by Jackson
+ */
+ @SuppressWarnings("unused")
+ public static MMappedQueryableSegmentizerFactory makeForSerialization()
Review Comment:
Removed it from this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
