sreemanamala commented on code in PR #16718: URL: https://github.com/apache/druid/pull/16718#discussion_r1673612644
########## sql/src/test/resources/calcite/tests/window/range_handling.sqlTest: ########## @@ -1,24 +0,0 @@ -type: "operatorValidation" - -sql: | - SELECT - FLOOR(m1/3), - DENSE_RANK() OVER (ORDER BY FLOOR(m1/3)), - 'prefix', - COUNT(1) OVER (ORDER BY FLOOR(m1/3) ROWS BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW), - COUNT(1) OVER (ORDER BY FLOOR(m1/3) RANGE BETWEEN UNBOUNDED PRECEDING AND CURRENT ROW), - 'postfix', - COUNT(1) OVER (ORDER BY FLOOR(m1/3) ROWS BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING), - COUNT(1) OVER (ORDER BY FLOOR(m1/3) RANGE BETWEEN CURRENT ROW AND UNBOUNDED FOLLOWING), - 'k(1)', - COUNT(1) OVER (ORDER BY FLOOR(m1/3) ROWS BETWEEN 1 PRECEDING AND 1 FOLLOWING), - COUNT(1) OVER (ORDER BY FLOOR(m1/3) RANGE BETWEEN 1 PRECEDING AND 1 FOLLOWING) Review Comment: yeah, make sense to just remove these 1 PRECEDING AND 1 FOLLOWING. Later on when we start supporting them, we can modify this test to keep the comparisons between ROWS and RANGE in different scenarios at one place. will update it. Thanks for the review @kgyrtkirk !! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
