This is an automated email from the ASF dual-hosted git repository.
lakshsingla pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/druid.git
The following commit(s) were added to refs/heads/master by this push:
new 760d70312fb Window Drill tests coverage improvement (#16722)
760d70312fb is described below
commit 760d70312fbc5c56cc187f10aca7ea19b506a75e
Author: Sree Charan Manamala <[email protected]>
AuthorDate: Thu Jul 11 19:11:36 2024 +0530
Window Drill tests coverage improvement (#16722)
Window Drill tests coverage improvement
---
.../java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java | 6 ++----
sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java | 3 +--
.../test/resources/drill/window/queries/aggregates/testW_Nulls_5.q | 2 +-
.../test/resources/drill/window/queries/aggregates/testW_Nulls_6.q | 2 +-
.../drill/window/queries/frameclause/subQueries/frmInSubQry_25.q | 2 +-
5 files changed, 6 insertions(+), 9 deletions(-)
diff --git
a/sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java
b/sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java
index baeb04fb561..cb7bed7e041 100644
--- a/sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java
+++ b/sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java
@@ -4236,7 +4236,7 @@ public class DrillWindowQueryTest extends
BaseCalciteQueryTest
windowQueryTest();
}
- @NotYetSupported(Modes.COLUMN_NOT_FOUND)
+ @NotYetSupported(Modes.AGGREGATION_NOT_SUPPORT_TYPE)
@DrillTest("frameclause/subQueries/frmInSubQry_25")
@Test
public void test_frameclause_subQueries_frmInSubQry_25()
@@ -4244,7 +4244,7 @@ public class DrillWindowQueryTest extends
BaseCalciteQueryTest
windowQueryTest();
}
- @NotYetSupported(Modes.INCORRECT_SYNTAX)
+ @NotYetSupported(Modes.VIEWS_NOT_SUPPORTED)
@DrillTest("nestedAggs/nstdWinView01")
@Test
public void test_nestedAggs_nstdWinView01()
@@ -5083,7 +5083,6 @@ public class DrillWindowQueryTest extends
BaseCalciteQueryTest
windowQueryTest();
}
- @NotYetSupported(Modes.COLUMN_NOT_FOUND)
@DrillTest("aggregates/testW_Nulls_5")
@Test
public void test_aggregates_testW_Nulls_5()
@@ -5091,7 +5090,6 @@ public class DrillWindowQueryTest extends
BaseCalciteQueryTest
windowQueryTest();
}
- @NotYetSupported(Modes.COLUMN_NOT_FOUND)
@DrillTest("aggregates/testW_Nulls_6")
@Test
public void test_aggregates_testW_Nulls_6()
diff --git
a/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
b/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
index a3f6208f112..5d53593b7ce 100644
--- a/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
+++ b/sql/src/test/java/org/apache/druid/sql/calcite/NotYetSupported.java
@@ -80,13 +80,12 @@ public @interface NotYetSupported
NOT_ENOUGH_RULES(DruidException.class, "not enough rules"),
ERROR_HANDLING(AssertionError.class, "targetPersona: is <[A-Z]+> and
category: is <[A-Z_]+> and errorCode: is"),
EXPRESSION_NOT_GROUPED(DruidException.class, "Expression '[a-z]+' is not
being grouped"),
- COLUMN_NOT_FOUND(DruidException.class,
"CalciteContextException.*Column.*not found in any table"),
NULLS_FIRST_LAST(DruidException.class, "NULLS (FIRST|LAST)"),
BIGINT_TO_DATE(DruidException.class, "BIGINT to type (DATE|TIME)"),
AGGREGATION_NOT_SUPPORT_TYPE(DruidException.class, "Aggregation
\\[(MIN|MAX)\\] does not support type \\[STRING\\]"),
ALLDATA_CSV(DruidException.class, "allData.csv"),
BIGINT_TIME_COMPARE(DruidException.class, "Cannot apply '.' to arguments
of type"),
- INCORRECT_SYNTAX(DruidException.class, "Incorrect syntax near the
keyword"),
+ VIEWS_NOT_SUPPORTED(DruidException.class, "Incorrect syntax near the
keyword 'CREATE'"),
RESULT_MISMATCH(AssertionError.class, "(assertResulEquals|AssertionError:
column content mismatch)"),
LONG_CASTING(AssertionError.class, "expected: java.lang.Long"),
UNSUPPORTED_NULL_ORDERING(DruidException.class, "(A|DE)SCENDING ordering
with NULLS (LAST|FIRST)"),
diff --git
a/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_5.q
b/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_5.q
index 30ecd90da00..8f4d929313f 100644
--- a/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_5.q
+++ b/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_5.q
@@ -1 +1 @@
-SELECT c1, c2, w_avg FROM ( SELECT c1, c2, avg ( c1 ) OVER ( PARTITION BY c2
ORDER BY c1 ASC nulls first ) w_AVG FROM "tblWnulls.parquet" ) sub_query WHERE
w_avg IS null
\ No newline at end of file
+SELECT c1, c2, w_avg FROM ( SELECT c1, c2, avg ( c1 ) OVER ( PARTITION BY c2
ORDER BY c1 ASC nulls first ) w_avg FROM "tblWnulls.parquet" ) sub_query WHERE
w_avg IS null
\ No newline at end of file
diff --git
a/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_6.q
b/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_6.q
index f41206b8860..accb07b4824 100644
--- a/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_6.q
+++ b/sql/src/test/resources/drill/window/queries/aggregates/testW_Nulls_6.q
@@ -1 +1 @@
-SELECT c1, c2, w_avg FROM ( SELECT c1, c2, avg ( c1 ) OVER ( PARTITION BY c2
ORDER BY c1 ASC nulls first ) w_AVG FROM "tblWnulls.parquet" ) sub_query
\ No newline at end of file
+SELECT c1, c2, w_avg FROM ( SELECT c1, c2, avg ( c1 ) OVER ( PARTITION BY c2
ORDER BY c1 ASC nulls first ) w_avg FROM "tblWnulls.parquet" ) sub_query
\ No newline at end of file
diff --git
a/sql/src/test/resources/drill/window/queries/frameclause/subQueries/frmInSubQry_25.q
b/sql/src/test/resources/drill/window/queries/frameclause/subQueries/frmInSubQry_25.q
index 5eddd9c7bef..552e2f7ee24 100644
---
a/sql/src/test/resources/drill/window/queries/frameclause/subQueries/frmInSubQry_25.q
+++
b/sql/src/test/resources/drill/window/queries/frameclause/subQueries/frmInSubQry_25.q
@@ -2,7 +2,7 @@ SELECT *
FROM
( SELECT MIN(c5) OVER W as w_min,
MIN(c5) OVER W2 as w2_min,
- MIN(C5) OVER W3 as w3_min
+ MIN(c5) OVER W3 as w3_min
FROM "t_alltype.parquet"
WINDOW W AS ( PARTITION BY c8 ORDER BY c1 RANGE BETWEEN UNBOUNDED
PRECEDING AND UNBOUNDED FOLLOWING ),
W2 AS ( PARTITION BY c8 ORDER BY c1 ROWS BETWEEN UNBOUNDED PRECEDING
AND CURRENT ROW ),
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
