trompa opened a new pull request, #16726:
URL: https://github.com/apache/druid/pull/16726
Fixes #16717
### Description
Hadoop ingestion doesnt have access to K8s config. Provider not being pure
lazy was making the HadoopIndexTask fail altho it doesnt really need K8s
information on the Hadoop cluster.
This PR refactors the DruidLeaderSelectorProvider class so its creation can
be deferred to Module instantiation, thus not happening on HadoopIndexTask
It creates 2 subclasses CoordinatorDruidLeaderSelectorProvider and
IndexingServiceDruidLeaderSelectorProvider which can be properly referenced.
Was not sure about either overriding the get method on children or keep the
parents, so i decided to take the option with less code changes.
Let me know if the other option id preferred.
#### Release note
<hr>
##### Key changed/added classes in this PR
* Fixed: Hadoop ingestion now works on k8s deployments
<hr>
This PR has:
- [ ] been self-reviewed.
- [ ] added documentation for new or modified features or behaviors.
- [ X] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ X] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
