abhishekrb19 commented on code in PR #16730:
URL: https://github.com/apache/druid/pull/16730#discussion_r1676691017
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -600,7 +580,7 @@ static Map<Interval, DataSchema>
createDataSchemasForIntervals(
}
}
- private static List<TimelineObjectHolder<String, DataSegment>>
retrieveRelevantTimelineHolders(
+ private static Iterable<DataSegment> retrieveRelevantTimelineHolders(
Review Comment:
I guess the objects being returned is still relevant to the timeline, but
does this method need a rename?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
