gargvishesh commented on code in PR #16737:
URL: https://github.com/apache/druid/pull/16737#discussion_r1679144831
##########
server/src/main/java/org/apache/druid/server/coordinator/compact/DatasourceCompactibleSegmentIterator.java:
##########
@@ -315,27 +291,12 @@ public List<DataSegment> next()
}
/**
- * Finds segments to compact together for the given datasource.
- *
- * @return An empty {@link SegmentsToCompact} if there are no eligible
candidates.
+ * Finds segments to compact together for the given datasource and adds them
to
+ * the priority queue.
*/
- private SegmentsToCompact findSegmentsToCompact(
- final String dataSourceName,
- final DataSourceCompactionConfig config
- )
+ private void findSegmentsToCompact(CompactibleSegmentIterator
compactibleSegmentIterator)
Review Comment:
```suggestion
private void findAndEnqueueSegmentsToCompact(CompactibleSegmentIterator
compactibleSegmentIterator)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
