Akshat-Jain commented on code in PR #16729:
URL: https://github.com/apache/druid/pull/16729#discussion_r1679570917
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessor.java:
##########
@@ -259,7 +258,7 @@ public ReturnOrAwait<Object> runIncrementally(IntSet
readableInputs)
if (outputRow == null) {
outputRow = currentRow;
objectsOfASingleRac.add(currentRow);
- } else if (comparePartitionKeys(outputRow, currentRow,
partitionColsIndex)) {
+ } else if (comparePartitionKeys(outputRow, currentRow,
partitionColumnNames)) {
Review Comment:
> and not construct all of them for every RAC
We aren't constructing the sort, partitioning and window operator for every
RAC, if that's what you meant. They are coming from `operatorFactoryList`
declared at class level.
`runAllOpsOnSingleRac` does have `new Operator()` though, do you mean that
this need not be constructed for every RAC?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
