clintropolis commented on code in PR #16673:
URL: https://github.com/apache/druid/pull/16673#discussion_r1680122290


##########
docs/querying/sql-data-types.md:
##########
@@ -34,12 +34,23 @@ Druid associates each column with a specific data type. 
This topic describes sup
 
 Druid natively supports the following basic column types:
 
-* LONG: 64-bit signed int
-* FLOAT: 32-bit float
-* DOUBLE: 64-bit float
-* STRING: UTF-8 encoded strings and string arrays
-* COMPLEX: non-standard data types, such as nested JSON, hyperUnique and 
approxHistogram, and DataSketches
-* ARRAY: arrays composed of any of these types
+* `LONG`: 64-bit signed int
+* `FLOAT`: 32-bit float
+* `DOUBLE`: 64-bit float
+* `STRING`: UTF-8 encoded strings and string arrays
+* `ARRAY`: arrays composed of any of these types
+
+## Complex types
+
+Druid natively supports the following complex types:
+* `COMPLEX<JSON>`: stores a copy of structured data in JSON format and 
specialized internal columns and indexes for nested basic types. Click here to 
learn more about [`COMPLEX<JSON>`](nested-columns.md)
+* `cardinality`: Data structure to compute the cardinality of Apache Druid 
dimensions using the HyperLogLog algorithm. Click here to learn more about 
[`cardinality`](hll-old.md#cardinality-aggregator)

Review Comment:
   That page _only_ describes the aggregator types which are specified on 
native json queries (SQL handles all of this automatically during planning). I 
believe most extension pages will be like this, describing the aggregator types 
you would use in native json queries, and describing SQL function signatures, 
but not describing how the type appears when ingested into a table.
   
   To clarify in this example, the `cardinality` and `hyperUnique` aggregators 
both spit out the type `COMPLEX< hyperUnique>`, the cardinality aggregator 
builds them from strings or numbers, and the hyperUnique aggregator merges them 
together



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to