edgar2020 commented on code in PR #16745: URL: https://github.com/apache/druid/pull/16745#discussion_r1681909695
########## docs/querying/sql-functions.md: ########## @@ -729,11 +790,30 @@ Rounds down a timestamp by a given time unit. ## FLOOR (numeric) -`FLOOR(<NUMERIC>)` +Rounds down to the largest integer value less than or equal to the numeric expression. Review Comment: I use "Round down ..." to be consistent with the definition used for `FLOOR (date and time)`. That said, it appears documentation from microsoft and w2schools use a similar definition to the original, so I will change it back to the original. I will do the same for CEIL as well -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
