cryptoe commented on code in PR #16711:
URL: https://github.com/apache/druid/pull/16711#discussion_r1683642083
##########
extensions-contrib/kubernetes-overlord-extensions/src/main/java/org/apache/druid/k8s/overlord/KubernetesTaskRunner.java:
##########
@@ -443,11 +443,17 @@ public Collection<TaskRunnerWorkItem> getPendingTasks()
@Override
public TaskLocation getTaskLocation(String taskId)
{
- final KubernetesWorkItem workItem = tasks.get(taskId);
- if (workItem == null) {
+ try {
+ final KubernetesWorkItem workItem = tasks.get(taskId);
+ if (workItem == null) {
+ return TaskLocation.unknown();
+ } else {
+ return workItem.getLocation();
+ }
+ }
+ catch (Exception e) {
+ log.warn("Unable to find location for task [%s]", taskId);
Review Comment:
Is there a reason we are not logging the exception ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
