Akshat-Jain commented on code in PR #16729:
URL: https://github.com/apache/druid/pull/16729#discussion_r1683874492
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/WindowOperatorQueryFrameProcessorFactory.java:
##########
@@ -61,21 +61,24 @@ public class WindowOperatorQueryFrameProcessorFactory
extends BaseFrameProcessor
private final RowSignature stageRowSignature;
private final boolean isEmptyOver;
private final int maxRowsMaterializedInWindow;
+ private final List<String> partitionColumnNames;
@JsonCreator
public WindowOperatorQueryFrameProcessorFactory(
@JsonProperty("query") WindowOperatorQuery query,
@JsonProperty("operatorList") List<OperatorFactory> operatorFactoryList,
@JsonProperty("stageRowSignature") RowSignature stageRowSignature,
@JsonProperty("emptyOver") boolean emptyOver,
- @JsonProperty("maxRowsMaterializedInWindow") int
maxRowsMaterializedInWindow
+ @JsonProperty("maxRowsMaterializedInWindow") int
maxRowsMaterializedInWindow,
+ @JsonProperty("partitionColumnNames") List<String> partitionColumnNames
Review Comment:
I am removing `emptyOver` in #16754, as it's redundant with
`partitionColumnNames`. My thinking was that it's okay to not worry about
backward compatibility, in favor of keeping a cleaner codebase - considering
this feature isn't GA yet.
Thoughts?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
