kgyrtkirk commented on code in PR #16738:
URL: https://github.com/apache/druid/pull/16738#discussion_r1683942555
##########
processing/src/main/java/org/apache/druid/query/rowsandcols/ArrayListRowsAndColumns.java:
##########
@@ -212,15 +212,8 @@ public <T> T as(Class<T> clazz)
@Override
public void addColumn(String name, Column column)
{
- if (rows.size() == numRows()) {
- extraColumns.put(name, column);
- columnNames.add(name);
- return;
- }
-
Review Comment:
instead of removing it entirely - possibly a check would be nice to ensure
that only columns which `ColumnValueSwapper` gets added like that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
