kgyrtkirk commented on issue #16715: URL: https://github.com/apache/druid/issues/16715#issuecomment-2238598418
@AlbericByte: sorry, I haven't seen a PR for it / further comments....next time I'll ask you about it. right now that PR only restrict it for window functions However it turned out that the situation is a bit more complicated than I was expecting when I've filed this issue - we can't just ban distinct usage for non-`count(distinct)` cases - as there are aggregators like [string_agg](https://github.com/apache/druid/blob/35b876436b8309188f38cb7639bce900c4a08d1d/sql/src/main/java/org/apache/druid/sql/calcite/aggregation/builtin/StringSqlAggregator.java#L154) which could do the `distinct` aggregation by themselves while translating to the native later... We were talking about introducing some annotation markers to enable the compiler to verify this and restrict it that way. But I'll reach out to you next time to avoid such a misunderstanding(s) - thank you for letting me know that you was not expecting the above! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
