techdocsmith commented on code in PR #16761: URL: https://github.com/apache/druid/pull/16761#discussion_r1687178443
########## docs/querying/sql-functions.md: ########## @@ -1133,11 +1152,26 @@ Returns the minimum value of a set of values. ## MOD -`MOD(x, y)` +Calculates x modulo y, or the remainder of x divided by y. Where x and y are numeric expressions. -**Function type:** [Scalar, numeric](sql-scalar.md#numeric-functions) +* **Syntax:** `MOD(x, y)` +* **Function type:** Scalar, numeric + +<details><summary>Example</summary> + +The following calculates 78 MOD 10. + +```sql +SELECT MOD(78, 10) as "mod" Review Comment: nit: suggest using an english word for the alias (kind of the point of an alias :D ) ########## docs/querying/sql-functions.md: ########## @@ -1446,11 +1515,26 @@ Calculates the trigonometric sine of an angle expressed in radians. ## SQRT -`SQRT(expr)` +Calculates the square root of a numeric expression. -**Function type:** [Scalar, numeric](sql-scalar.md#numeric-functions) +* **Syntax:** `SQRT(<NUMERIC>)` +* **Function type:** Scalar, numeric -Calculates the square root of a numeric expression. +<details><summary>Example</summary> + +The following example applies SQRT to the `trip_distance` column from the `taxi-trips` datasource. Review Comment: This appears to be a static select that does not use the data from `taxi-trips` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
