kgyrtkirk commented on code in PR #16733: URL: https://github.com/apache/druid/pull/16733#discussion_r1687809535
########## sql/src/test/resources/calcite/tests/window/shuffleOperators.sqlTest: ########## @@ -0,0 +1,72 @@ +type: "operatorValidation" + +sql: | + SELECT + countryName, + cityName, + __time, + ROW_NUMBER() OVER (PARTITION BY countryName ORDER BY cityName), + ROW_NUMBER() OVER (ORDER BY countryName desc, cityName), + ROW_NUMBER() OVER (ORDER BY countryName, cityName), + ROW_NUMBER() OVER (PARTITION BY cityName), + ROW_NUMBER() OVER () + FROM wikipedia + where page < '0' and channel like '#en%' + +expectedOperators: + - type: "naivePartition" + partitionColumns: [ ] + - type: "window" + processor: + type: "rowNumber" + outputColumn: "w4" + - type: "naiveSort" + columns: + - column: "cityName" + direction: "ASC" + - type: "naivePartition" + partitionColumns: [ "cityName" ] + - type: "window" + processor: + type: "rowNumber" + outputColumn: "w3" + - type: "naiveSort" + columns: + - column: "countryName" + direction: "ASC" + - column: "cityName" + direction: "ASC" + - type: "naivePartition" + partitionColumns: [ ] Review Comment: is this empty `partitionColumns` expected? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
