bsyk commented on code in PR #16564:
URL: https://github.com/apache/druid/pull/16564#discussion_r1690418147
##########
extensions-contrib/spectator-histogram/src/main/java/org/apache/druid/spectator/histogram/SpectatorHistogramIndexBasedComplexColumn.java:
##########
@@ -59,72 +53,11 @@ public Object getRowValue(int rowNum)
@Override
public int getLength()
{
- return index.size();
+ return -1;
Review Comment:
If it's not important then -1 seems fine.
We can very likely compute (or estimate an upper bound) of the size of the
column if it will optimize something elsewhere.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
