kgyrtkirk commented on code in PR #16801:
URL: https://github.com/apache/druid/pull/16801#discussion_r1691033565
##########
sql/src/main/java/org/apache/druid/sql/calcite/planner/DruidSqlValidator.java:
##########
@@ -796,6 +797,20 @@ public void validateCall(SqlCall call, SqlValidatorScope
scope)
super.validateCall(call, scope);
}
+ @Override
+ protected void validateWindowClause(SqlSelect select)
+ {
+ SqlNodeList windows = select.getWindowList();
+ for (SqlNode sqlNode : windows) {
+ if (SqlUtil.containsAgg(sqlNode)) {
+ throw
DruidException.forPersona(DruidException.Persona.USER).ofCategory(DruidException.Category.UNSUPPORTED)
Review Comment:
in this class all exceptions should be emitted with a link to the
context(`sqlNode`) they appear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
