rohangarg commented on code in PR #16742:
URL: https://github.com/apache/druid/pull/16742#discussion_r1691131168
##########
sql/src/main/java/org/apache/druid/sql/calcite/expression/Expressions.java:
##########
@@ -238,6 +241,10 @@ public static DruidExpression
toDruidExpressionWithPostAggOperands(
final SqlKind kind = rexNode.getKind();
if (kind == SqlKind.INPUT_REF) {
return inputRefToDruidExpression(rowSignature, rexNode);
+ } else if (rexNode instanceof RexOver) {
+ throw new CannotBuildQueryException(
+ StringUtils.format("Encountered an OVER during Filter translation
[%s].", rexNode)
Review Comment:
Agreed that it will fail for sure, what I meant to point was that I'm unsure
about the error message `Encountered an OVER during Filter translation` - it
doesn't seem that only the filter translation code flow goes through this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
