github-advanced-security[bot] commented on code in PR #16803:
URL: https://github.com/apache/druid/pull/16803#discussion_r1691299483
##########
server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java:
##########
@@ -90,21 +76,15 @@
@Test
public void testSerdeWithMaxRowsPerSegment() throws IOException
{
- final DataSourceCompactionConfig config = new DataSourceCompactionConfig(
- "dataSource",
- null,
- 500L,
- 30,
- new Period(3600),
- null,
- null,
- null,
- null,
- null,
- null,
- CompactionEngine.MSQ,
- ImmutableMap.of("key", "val")
- );
+ final DataSourceCompactionConfig config = DataSourceCompactionConfig
+ .builder()
+ .forDataSource("dataSource")
+ .withInputSegmentSizeBytes(500L)
+ .withMaxRowsPerSegment(30)
Review Comment:
## Deprecated method or constructor invocation
Invoking [DataSourceCompactionConfigBuilder.withMaxRowsPerSegment](1) should
be avoided because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7600)
##########
server/src/test/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigTest.java:
##########
@@ -172,42 +125,14 @@
@Test
public void testSerdeMaxTotalRowsWithMaxRowsPerSegment() throws IOException
{
- final DataSourceCompactionConfig config = new DataSourceCompactionConfig(
- "dataSource",
- null,
- 500L,
- 10000,
- new Period(3600),
- new UserCompactionTaskQueryTuningConfig(
- null,
- null,
- null,
- 10000L,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null,
- null
- ),
- null,
- null,
- null,
- null,
- null,
- null,
- ImmutableMap.of("key", "val")
- );
-
+ final DataSourceCompactionConfig config = DataSourceCompactionConfig
+ .builder()
+ .forDataSource("dataSource")
+ .withInputSegmentSizeBytes(500L)
+ .withMaxRowsPerSegment(10000)
Review Comment:
## Deprecated method or constructor invocation
Invoking [DataSourceCompactionConfigBuilder.withMaxRowsPerSegment](1) should
be avoided because it has been deprecated.
[Show more
details](https://github.com/apache/druid/security/code-scanning/7601)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
