FrankChen021 commented on PR #16740: URL: https://github.com/apache/druid/pull/16740#issuecomment-2252486653
> Use JavaType instead of Class - This is another free bit of optimization that can help with the runtime. Class is converted into JavaType before the mapper deserializes the value. Directly having the JavaType ready means that the per entity deserialization doesn't have to incur this cost. Hi @LakshSingla I'm wondering how much performance gain this would bring in? I didn't find any doc about such performance overhead by using the Class object. And if we need to forbide the readValues method with the Class type? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
