gianm commented on code in PR #16790:
URL: https://github.com/apache/druid/pull/16790#discussion_r1693371029
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerClient.java:
##########
@@ -77,20 +81,21 @@ void postResultsComplete(
/**
* Client side method to inform the controller that the error has occured in
the given worker.
+ *
+ * @param queryId query ID, if this error is associated with a specific
query
+ * @param errorWrapper error details
*/
void postWorkerError(
- String workerId,
+ @Nullable String queryId,
MSQErrorReport errorWrapper
) throws IOException;
/**
* Client side method to inform the controller about the warnings generated
by the given worker.
*/
- void postWorkerWarning(
- List<MSQErrorReport> MSQErrorReports
- ) throws IOException;
+ void postWorkerWarning(List<MSQErrorReport> MSQErrorReports) throws
IOException;
- List<String> getTaskList() throws IOException;
+ List<String> getWorkerIds() throws IOException;
Review Comment:
Added javadoc.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
