kfaraz commented on code in PR #16810:
URL: https://github.com/apache/druid/pull/16810#discussion_r1696204677
##########
server/src/main/java/org/apache/druid/server/coordinator/DataSourceCompactionConfigAuditEntry.java:
##########
@@ -50,7 +51,7 @@ public DataSourceCompactionConfigAuditEntry(
}
@JsonProperty
- public GlobalCompactionConfig getGlobalConfig()
+ public ClusterCompactionConfig getGlobalConfig()
Review Comment:
`globalConfig` is also a term used by the web-console.
Renaming this getter would require us to use `@JsonProperty("globalConfig")`
on the getter for backwards compatibility. Leaving the names as is seemed
cleaner.
Let me know if you feel strongly about this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
