abhishekrb19 commented on code in PR #16841:
URL: https://github.com/apache/druid/pull/16841#discussion_r1704544575
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -157,6 +161,11 @@ public class SystemSchema extends AbstractSchema
.add("replication_factor", ColumnType.LONG)
.build();
+ static final int SEGMENTS_SHARD_SPEC_INDEX =
SEGMENTS_SIGNATURE.indexOf("shard_spec");
+ static final int SEGMENTS_DIMENSIONS_INDEX =
SEGMENTS_SIGNATURE.indexOf("dimensions");
+ static final int SEGMENTS_METRICS_INDEX =
SEGMENTS_SIGNATURE.indexOf("metrics");
+ static final int SEGMENTS_LAST_COMPACTION_STATE_INDEX =
SEGMENTS_SIGNATURE.indexOf("last_compaction_state");
Review Comment:
nit: all of these can be `private static`
##########
sql/src/main/java/org/apache/druid/sql/calcite/schema/SystemSchema.java:
##########
@@ -241,7 +250,7 @@ public Map<String, Table> getTableMap()
/**
* This table contains row per segment from metadata store as well as served
segments.
*/
- static class SegmentsTable extends AbstractTable implements ScannableTable
+ static class SegmentsTable extends AbstractTable implements ScannableTable,
ProjectableFilterableTable
Review Comment:
Do we still need to implement `ScannableTable`? I'd think the new
`scan(DataContext, List<RexNode>, int[])` signature would come with empty
filters and null projects if it's not present in the query
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
