cheddar commented on PR #16700: URL: https://github.com/apache/druid/pull/16700#issuecomment-2271689319
I had some off-line conversations with Zoltan about his comments. He's got some great comments for cleaning things up. I like eliminating SemanticUtils and just putting it on the interface that we use for the `.as()` method. And I believe that having the `RowSignature` alongside the `Frame` is a good thing. We will allow them to be done in future PRs, so I'm going to merge this as is. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
