cheddar commented on PR #16708: URL: https://github.com/apache/druid/pull/16708#issuecomment-2271718473
Just looking at the comments, it looks like things have generally been addressed. Clint has an outstanding comment about the semantics of the ColumnAccessor interface, which are valid but also not the central theme of this PR. As such, I don't see a reason to delay the merge of these changes, so going to push the merge button. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
