imply-cheddar commented on PR #16707: URL: https://github.com/apache/druid/pull/16707#issuecomment-2272174319
The test failure is weird. The way that the current test is parameterized makes it incredibly hard to figure out which is broken, in fact that whole pattern of parameterization is probably counter productive (you can just have each thing be its own test and share the test-execution code). I cannot push directly to this branch, so I instead did a PR against the branch at https://github.com/adarshsanjeev/druid/pull/2 The PR updates the test to hopefully be something that continues to test what the test here was trying to test and avoids the challenges. That said, I couldn't reproduce the test failure myself, so I'm not really sure why it's sad... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
